Improve escape deprecation message #4344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 26, 2024
0ba5cfa to
58de32a
Compare
stof
approved these changes
Sep 26, 2024
Contributor
|
Thank you @ruudk. |
58de32a to
7256713
Compare
Contributor
|
Would it be possible to add the source path (if it exists) ? It took me time to figure where one came from in my code (spoiler alert: a date format 😅) |
fabpot
added a commit
that referenced
this pull request
Oct 11, 2024
This PR was merged into the 3.x branch. Discussion ---------- Improve deprecation messages Refs [in string should](#4344 (comment)) cc `@smnandre` Commits ------- ed1b444 Improve deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #4176
According to #4343 the message can be improved.
I made a few changes to the test to make it easier to work with. Best to review this PR commit by commit.
/cc @stof