Add support for PHPUnit 11#4317
Closed
MauricioFauth wants to merge 2 commits into
Closed
Conversation
- Adds static data providers for Twig\Test\IntegrationTestCase. Running PHPUnit 10+ will require Twig\Test\IntegrationTestCase::getFixturesDirectory() to be implemented. - Removes the Twig\Test\NodeTestCase::getTests() data provider from the DataProvider attribute. This way it doesn't get called with PHPUnit 10+ causing the tests to fail. Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Contributor
|
I'm closing here as the work to support PHPUnit 11 has been done in Twig 4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test cases
Twig\Test\NodeTestCaseandTwig\Test\IntegrationTestCaseare currently incompatible with PHPUnit 11.This pull request adds an option to the user to add support to run the tests with PHPUnit 11, if they implement the
Twig\Test\IntegrationTestCase::getFixturesDirectory()method. Currently the only solution to the user is to forkIntegrationTestCaseandNodeTestCasetest cases, and run them only for PHPUnit 11.The difference from the previous pull request is that this time, if
getFixturesDirectory()is not implemented, it does not run the tests and trigger a deprecation, instead of causing an error.