Skip to content

Make Environment::getGlobals() private#4075

Merged
fabpot merged 1 commit into
twigphp:4.xfrom
fabpot:env-get-globals-private
Jul 5, 2024
Merged

Make Environment::getGlobals() private#4075
fabpot merged 1 commit into
twigphp:4.xfrom
fabpot:env-get-globals-private

Conversation

@fabpot

@fabpot fabpot commented May 4, 2024

Copy link
Copy Markdown
Contributor

No description provided.

jdreesen
jdreesen reviewed May 4, 2024
View reviewed changes
Comment thread tests/EnvironmentTest.php Outdated
@fabpot fabpot force-pushed the env-get-globals-private branch from ecc0936 to 9458c8a Compare May 5, 2024 07:12
xabbuh
xabbuh reviewed May 6, 2024
View reviewed changes
Comment thread tests/EnvironmentTest.php Outdated
@fabpot fabpot force-pushed the env-get-globals-private branch 4 times, most recently from 4c0ef2a to d7d9511 Compare July 5, 2024 06:03
@fabpot fabpot force-pushed the env-get-globals-private branch from d7d9511 to 6f4e6e7 Compare July 5, 2024 06:05
@fabpot fabpot merged commit 90d3b52 into twigphp:4.x Jul 5, 2024
@fabpot fabpot deleted the env-get-globals-private branch July 5, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jdreesen jdreesen jdreesen left review comments
@xabbuh xabbuh xabbuh left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabpot @jdreesen @xabbuh