Accept CRLF line endings in .ormolu files#969
Merged
Conversation
629efaf to
0dc3ac2
Compare
amesgen
approved these changes
Jan 17, 2023
Contributor
amesgen
left a comment
There was a problem hiding this comment.
I think the reason why we are even seeing these CRLFs is due to us using the functions from Ormolu.Utils.IO which (transitively) uses withBinaryFile instead of withFile as Data.Text.IO.readFile does, but this indeed the right thing to do (see #760 or the Haddocks of Data.Text.IO.readFile).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.