Skip to content

Indent post-guard expression one level more#813

Merged
mrkkrp merged 1 commit intomasterfrom
tbagrel1/806-indent-after-guard
Oct 21, 2021
Merged

Indent post-guard expression one level more#813
mrkkrp merged 1 commit intomasterfrom
tbagrel1/806-indent-after-guard

Conversation

@tbagrel1
Copy link
Member

Closing #806

@tbagrel1 tbagrel1 requested a review from mrkkrp October 21, 2021 15:01
@tbagrel1 tbagrel1 linked an issue Oct 21, 2021 that may be closed by this pull request
@mrkkrp mrkkrp force-pushed the tbagrel1/806-indent-after-guard branch 2 times, most recently from eb372b0 to 9f3474a Compare October 21, 2021 16:01
@mrkkrp mrkkrp force-pushed the tbagrel1/806-indent-after-guard branch from 9f3474a to 7399022 Compare October 21, 2021 16:05
@mrkkrp mrkkrp merged commit c222964 into master Oct 21, 2021
@mrkkrp mrkkrp deleted the tbagrel1/806-indent-after-guard branch October 21, 2021 16:10
5 -> True
_ -> False
5 -> True
_ -> False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm the change doesnt look as good for this one, or the one with the wrapped || operator. nothing to fix, just commenting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but I think overall it is an improvement for readability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in #712, one can add a line break after the = sign, and it would give a much better output :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indent post-guard expression one level more

3 participants