Fix rendering of regular record updates with RDP enabled#706
Merged
mrkkrp merged 1 commit intotweag:masterfrom May 13, 2021
Merged
Fix rendering of regular record updates with RDP enabled#706mrkkrp merged 1 commit intotweag:masterfrom
mrkkrp merged 1 commit intotweag:masterfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #701.
This pull request solves the "second half" of the idempotency bug presented in #701, but there is a another bug (the "first half") for which I do not see an obvious solution. Since the other bug is not directly related to this, I've opened a separate Issue where I explain the problem in detail, see #705.
When Ormolu checks if a record update conforms to the RDP syntax (no space before the opening brace), it compares the column numbers of the relevant source spans but not the line numbers. This is why a regular record update of the form
{-# OPTIONS_GHC -fplugin=RecordDotPreprocessor #-} def { g = 1 }where the start / end columns of the expression
defand the fieldgare aligned in a specific way, "tricks" Ormolu into thinking that this is an RDP record update, even when it is clearly not. The formatting result looks like this:{-# OPTIONS_GHC -fplugin=RecordDotPreprocessor #-} def{g = 1 }For the same reason the second code snippet from #701 gets formatted the way it is. Fortunately, the problem is simply solved by checking if the relevant source spans are on the same line.