Avoid modifying correctly-formatted files.#649
Merged
mrkkrp merged 1 commit intotweag:masterfrom Sep 6, 2020
SamirTalwar:do-not-modify-formatted-files
Merged
Avoid modifying correctly-formatted files.#649mrkkrp merged 1 commit intotweag:masterfrom SamirTalwar:do-not-modify-formatted-files
mrkkrp merged 1 commit intotweag:masterfrom
SamirTalwar:do-not-modify-formatted-files
Conversation
Currently, when running with `--mode=inplace`, Ormolu always overwrites the files, even when nothing has changed, updating the modified timestamp of the file. This encourages Stack to rebuild everything when only one file has changed. A quick check to see if the file needs rewriting solves this problem. I would prefer the API allowed me to only read the file once, but as the `--mode=check` logic also reads the file twice, I decided this wasn't the biggest sin for now.
Member
|
Thanks! |
Contributor
Author
|
No problem. Looking forward to this hitting nixpkgs-unstable. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when running with
--mode=inplace, Ormolu always overwrites the files, even when nothing has changed, updating the modified timestamp of the file. This encourages Stack to rebuild everything when only one file has changed.A quick check to see if the file needs rewriting solves this problem.
I would prefer the API allowed me to only read the file once, but as the
--mode=checklogic also reads the file twice, I decided this wasn't the biggest sin for now.