Format type applications of QuasiQuotes correctly#1135
Merged
Conversation
p4l1ly
approved these changes
Sep 16, 2024
mrkkrp
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1134
This PR basically reverts #616 (but keeps the tests that were added there), which was necessary back then, but no longer is due to GHC proposal 229 ("Whitespace-sensitive operator parsing").
Concretely, the example from #613/#616
is nowadays always parsed as an application of the (value-level) operator
@to two value-level arguments, in contrast to a type application back then (whenTypeApplicationswas enabled). Hence, we don't need to handle anything specially here by inserting extra spaces.This fixes the bug because
HsSpliceTyis also used to representQuasiQuotes.