Add instance Consumable/Dupable/Movable for ByteString, ShortByteString and Text#501
Merged
aspiwack merged 1 commit intotweag:masterfrom Feb 25, 2026
Merged
Conversation
Member
|
Immutable isn't sufficient. But because they have a single closure at the root, I agree, all these things are |
…ng and Text As discussed in tweag#412, `linear-base` already depends on `text` and (transitively) on `bytestring`. The types in question are simple immutable data with WHNF = NF, so they are trivially `Movable`.
c4037a5 to
5a59388
Compare
Contributor
Author
|
@aspiwack pushed a fix for Ormolu, it should be good now. |
aspiwack
approved these changes
Feb 25, 2026
Member
|
I'll cut a release with this (I think it's going to be purely a type-class-instance related release), probably tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #412.
ByteString,ShortByteStringandTextare simple immutable data, so they are triviallyMovable.linear-basealready depends ontextand (transitively) onbytestring, so this does not incur new dependencies.