do not drop extra elements in Data.List.Linear drop and take#486
do not drop extra elements in Data.List.Linear drop and take#486aspiwack merged 4 commits intotweag:masterfrom exaexa:patch-1
Conversation
|
(I also pushed an update that fixes the errors reported by CI) |
b-mehta
left a comment
There was a problem hiding this comment.
Can you add a test for this, in test/Test/Data/List.hs?
|
@b-mehta Hi, I'm not sure about what the tests should look like (I'm not really good with linear haskell, fixed this basically as a passer-by on the IRC...), and unfortunately currently I don't have much time to investigate. Any help would be apprectiated. cc @liamzee (who found this originally) could have some test material |
|
I can do it, no worries. Thank all three of you @liamzee , @tomsmeding , @exaexa for finding the bug and coming up with a fix. |
|
@b-mehta would you have a look at my tests and tell me if they make sense to you? If you'd like to see more? |
aspiwack
left a comment
There was a problem hiding this comment.
Alright, then! Let me approve. I'll merge as soon as CI passes.
Thanks @b-mehta for the review. It seems that you don't have write access, this is silly, in case you do more reviews like this in the future, I've sent you an invite with the appropriate permission.
Fixes #484 .