Merged
Conversation
aspiwack
reviewed
May 3, 2023
Comment on lines
-10
to
+11
| [ hmbench, | ||
| Array.benchmarks | ||
| [ Array.benchmarks, | ||
| HashMap.benchmarks |
Member
There was a problem hiding this comment.
Any reason for switching these two around?
Member
Author
There was a problem hiding this comment.
I added some consistency around the import naming scheme, and I reordered them to follow both alphabetical order and the import order.
Member
There was a problem hiding this comment.
I don't see much value in alphabetical ordering of the benchmarks. But it doesn't hurt either, I suppose.
aspiwack
approved these changes
May 3, 2023
Comment on lines
-10
to
+11
| [ hmbench, | ||
| Array.benchmarks | ||
| [ Array.benchmarks, | ||
| HashMap.benchmarks |
Member
There was a problem hiding this comment.
I don't see much value in alphabetical ordering of the benchmarks. But it doesn't hurt either, I suppose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces the
gaugebenchmark framework withtasty-benchfor thelinear-base:benchtarget. The API is the same in both tools, so the change is mostly transparent.