Conversation
- The directory is name `src-<something>` so as to be listed closed to `src`. - It contains a sub-directory for each version where a change needs to be enacted. Which avoids having to duplicate files between version, or a complicated combinatorics in the cabal file.
|
@matthew-healy since you participated in the previous such occurrence, would you have a look and tell me what you think of the general plan? (I'm sparing @jeicher because I know he wants to focus on his client's work at present). |
|
@aspiwack Sure thing! From a very cursory glance it looks reasonable, but I'll take a more in-depth look tomorrow morning just to make sure. |
|
Using a quick and dirty matrix job to check against more versions of GHC. I'll have to fiddle with the branch protection options to reflect this. |
| @@ -0,0 +1,16 @@ | |||
| {-# LANGUAGE LinearTypes #-} | |||
| module Data.Tuple.Linear.Compat where | |||
There was a problem hiding this comment.
I'm pondering whether I want Data.Tuple.Linear.Compat to be hidden in Haddock as an internal module (applies to both copies).
|
Some bikeshedding thoughts to ponder:
|
|
I've tried using a more recent Nixpkgs version, but for whatever reason it ends up rebuilding a large proportion of the Haskell dependencies. I don't have time to investigate, and it would break CI. Maybe I'll join testing on GHC 9.6 with dropping support for GHC 9.2. @guibou I'd be appreciative if you could test this version with GHC 9.6 before I merge. |
In GHC 9.6, the `Solo` data constructor was renamed to `MkSolo`. We make a compatibility file to address this.
|
Actually, it was a bit hacky, but I managed to test with GHC 9.6. I think that most of the issues with Nix are in haskell-language-server and its dependencies. So it may be fixable, but I won't have time today. I'll merge as soon as CI is green. |
This pull request makes linear-base compatible with GHC 9.6.
I've moved the compatibility files around to permit for many version transitions if we need to (even if I plan to drop 9.2 support soon).
Draft because this is very not done
SoloinstancesUpdate Nixpkgs to a version with GHC 9.6 in itAdd 9.6 to CICloses #437