Add some Handle operations to RIO#425
Merged
aspiwack merged 6 commits intotweag:masterfrom Aug 29, 2022
Merged
Conversation
endgame
commented
Aug 13, 2022
aspiwack
reviewed
Aug 23, 2022
Member
aspiwack
left a comment
There was a problem hiding this comment.
A few comments to address below, and it'll be good to go.
Next release is likely to ship breaking changes. Co-authored-by: Arnaud Spiwack <arnaud@spiwack.net>
Co-authored-by: Arnaud Spiwack <arnaud@spiwack.net>
endgame
commented
Aug 23, 2022
Contributor
Author
endgame
left a comment
There was a problem hiding this comment.
I applied all your suggestions.
aspiwack
approved these changes
Aug 29, 2022
Member
aspiwack
left a comment
There was a problem hiding this comment.
I edited the title of the PR for clarity. I'll be merging now. Thanks for your PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
System.IO.Resource.Linear.{openBinaryFile,hSeek,SeekMode(..),hTell}.Haddocks are in anticipation of a near 0.2.1 release; happy to change/remove the
@sinceannotations if they're likely to be wrong.Related: #424.