Skip to content

Don't use deprecated testProperty from tasty-hedgehog#415

Merged
aspiwack merged 1 commit intomasterfrom
update/20220505/tasty-hedgehog
May 6, 2022
Merged

Don't use deprecated testProperty from tasty-hedgehog#415
aspiwack merged 1 commit intomasterfrom
update/20220505/tasty-hedgehog

Conversation

@aspiwack
Copy link
Copy Markdown
Member

@aspiwack aspiwack commented May 5, 2022

The testProperty function has been deprecated in the current 1.2
version. See qfpl/tasty-hedgehog#42 for the
reason.

The testProperty function is replaced by testPropertyNamed which
requires one extra argument (the name of the test function as a
string).

There were a test for which the property didn't have a name, so I had
to name it. We also need -XOverloadedString in every module (some
already have it).


This is extracted from #414 , which was supposed to be a 5min fix and turned
out to spiral out of control. I realised it was possible to turn it back into a 5min
fix: add the more recent version of tasty-hedgehog to the extra-deps.

@aspiwack aspiwack requested a review from tbagrel1 May 5, 2022 12:26
@aspiwack aspiwack mentioned this pull request May 5, 2022
2 tasks
The `testProperty` function has been deprecated in the current 1.2
version. See qfpl/tasty-hedgehog#42 for the
reason.

The `testProperty` function is replaced by `testPropertyNamed` which
requires one extra argument (the name of the test function as a
string).

There were a test for which the property didn't have a name, so I had
to name it. We also need `-XOverloadedString` in every module (some
already have it).
@aspiwack aspiwack force-pushed the update/20220505/tasty-hedgehog branch from 9e71452 to 43f9275 Compare May 5, 2022 12:33
Copy link
Copy Markdown
Member

@tbagrel1 tbagrel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aspiwack aspiwack merged commit 4fd6e84 into master May 6, 2022
@aspiwack aspiwack deleted the update/20220505/tasty-hedgehog branch May 6, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants