Finish robustness improvements on make/elim#391
Merged
Conversation
tbagrel1
commented
Feb 21, 2022
tbagrel1
commented
Feb 21, 2022
aspiwack
reviewed
Feb 21, 2022
228c646 to
722abdc
Compare
722abdc to
9a1d692
Compare
aspiwack
approved these changes
Feb 25, 2022
Comment on lines
+137
to
+140
| -- About the constraints of this function (they won't get in your way): | ||
| -- | ||
| -- * @'Elim' ('NatToPeano' n) a b@ provides the actual implementation of 'elim'; there is an instance of this class for any @(n, a, b)@ | ||
| -- * @'IsFunN' a b f, f ~ 'FunN' ('NatToPeano' n) a b, n ~ 'Arity' b f@ indicate the shape of @f@ to the typechecker (see documentation of 'IsFunN'). |
+ Rework `V.{make,elim}` to use the same type-level machinery as
`Replicator.elim`
+ Improve documentation of `V.{make,elim}`, `Replicator.elim` and `Arity` module
+ Expose the type-level helpers from the internal `Arity` module as `Data.Arity.Linear`
+ Add explicit comments in docstrings of make/elim about constraints
Co-authored-by: Arnaud Spiwack <arnaud@spiwack.net>
1ef1fd4 to
97d8e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V.{make,elim}to use the same type-level machinery asthe new
Replicator.elimimplementation introduced by @aspiwack in A more robust implementation of Replicator.elim #390V.{make,elim},Replicator.elimandAritymoduleAritymodule asData.Arity.Linear