Force eta-expansion of {Replicator,V}.elim#382
Merged
Conversation
(and move `make` into the `Make` class for consistency with `Elim`)
tbagrel1
commented
Feb 15, 2022
| -- > elim @3 :: (a %1 -> a %1 -> a %1 -> b) %1 -> V 3 a %1 -> b | ||
| elim :: f %1 -> V n a %1 -> b | ||
| elim f v = elim' f v | ||
| {-# INLINEABLE elim #-} |
Member
Author
There was a problem hiding this comment.
For obscure reasons, the {-# INLINABLE #-} pragma is necessary for V.elim (but not Replicator.elim). Also, neither INLINE nor NOINLINE work in this context. It seems that the contexts where something INLINABLE gets inlined are not completely contained in the contexts where something INLINE gets inlined.
aspiwack
approved these changes
Feb 15, 2022
Member
aspiwack
left a comment
There was a problem hiding this comment.
We may want to look for more robust methods to enforce inlining eventually. But this is better than the current situation, so let's go for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicator.elimandV.elimare currently not inlined if they are not fully applied (as we found out when writing inspection tests for this method). For example, in the following case,elimdoesn't get inlined:This PR renames
elimtoelim'and add aelimwrapper ensuring thatelim'can always get inlined.(I also move
makeinto theMakeclass in this PR, for consistency withElim)Closes #369 .