Enable doctesting through cabal-docspec#361
Merged
andreabedini merged 1 commit intomasterfrom Jan 19, 2022
Merged
Conversation
aspiwack
approved these changes
Jan 19, 2022
| name = "cabal-docspec"; | ||
|
|
||
| src = pkgs.fetchurl { | ||
| url = "https://github.com/phadej/cabal-extras/releases/download/cabal-docspec-0.0.0.20211114/cabal-docspec-0.0.0.20211114.xz"; |
Member
There was a problem hiding this comment.
Honestly, considering the constraints, this may be the best solution available to us, since it seems to be working well enough.
Contributor
Author
There was a problem hiding this comment.
I would think so. In the end, we are not redistributing nor depending on cabal-docspec. It's an utility anyone can use to run the doctests. Perhaps I could include some instructions about getting and using cabal-docspec, from a developer point of view.
Member
|
I think this will need no further modification for the time being. Please merge if you're ok with it. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables doctests using cabal-docspec
cabal-docspec has some advantages:
This PR:
terrible way, downloading the precompiled binary from github. I would
appreciate any help.
is a bit more picky about what it puts in scope.
This PR superseeds #317.