Add Consumable and Dupable instances to V#324
Merged
Divesh-Otwani merged 1 commit intomasterfrom Apr 13, 2021
Merged
Conversation
Divesh-Otwani
approved these changes
Apr 13, 2021
Comment on lines
+149
to
+151
| -- XXX: The Consumable and Dupable instances for V will be easier to define (in | ||
| -- fact direct, we may consider adding a deriving-via combinator) when we have a | ||
| -- traversable-by-a-data-applicative class see #190. |
Contributor
There was a problem hiding this comment.
This is a confusing comment but I'm going to assume there's a clear explanation of what it means in #190.
Comment on lines
+156
to
+159
| instance (KnownNat n, Dupable a) => Dupable (V n a) where | ||
| dupV (V xs) = | ||
| V . Unsafe.toLinear (Vector.fromListN (theLength @n)) Data.<$> | ||
| dupV (Unsafe.toLinear Vector.toList xs) |
Contributor
There was a problem hiding this comment.
I don't know why you would need this but OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310 .