Expose all data constructors via .Internal modules (close #305)#306
Merged
aspiwack merged 1 commit intotweag:masterfrom Feb 17, 2021
Merged
Expose all data constructors via .Internal modules (close #305)#306aspiwack merged 1 commit intotweag:masterfrom
aspiwack merged 1 commit intotweag:masterfrom
Conversation
Member
|
It does look quite reasonable to me. I'll run CI manually then merge. (I'm rather unsatisfied with our current CI setup, it outlived it's justification. We'll fix it soon) |
Member
|
CI passes locally. Let me merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a seemingly viable patch for #305.
I'm throwing this over the fence, feel free to take it as is, or build your own version, suited to your tastes, but at least building locally against this I can proceed for now.