Consistent parameter ordering of linear collections#242
Merged
Conversation
If anything, `alterF` is part of the optics story (it's a lens in the style of #197). But it's also generally useful, if rarely so. Also exposes `alter` (which has been mysteriously forgotten) and `alterF` in the export list.
aspiwack
approved these changes
Oct 2, 2020
Co-authored-by: Arnaud Spiwack <arnaud.spiwack@tweag.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147 .
This PR updates the mutable collections API slightly to have consistency on order of parameters. The issue #147 has more reasoning behind the changes, but in short:
set,get,lookup)read,write)For arrays and vectors, we both
setandgetmethods alongside with the flipped versions asreadandwrite(and their unsafe variants). However, unlifted arrays, maps and sets only have an entirely pure-looking interface. The only reason is that I did not find much value duplicating the entire API and making up new names for imperative-looking counterparts.Let me know if you have another preference.