Merged
Conversation
This removes a bounds check when the user is sure that the given index is within bounds. This is the case with vectors, since it does its own bounds-checking.
Divesh-Otwani
suggested changes
Sep 9, 2020
Contributor
Divesh-Otwani
left a comment
There was a problem hiding this comment.
A few minor changes -- feel free to merge directly after addressing them 😄
Divesh-Otwani
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements mutable vectors in terms of mutable arrays; removing the duplicated logic and some unsafe calls. The existing tests pass, and the module still provides the same interface.
Here are the major changes:
readUnsafeandwriteUnsafefunctions which omit bounds-checking.(size, capacity). Thecapacitynow can be obtained from the size of the underlying array.Closes #144. Also, a prerequisite of #165.