Preparing for release: api and documentation #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
reviewed
Mar 6, 2020
aherrmann
reviewed
Mar 6, 2020
Since we are advertising to import capability modules unqualified, having a type family like `All` exported in these module would pollute the global namespace. This is a bad idea. I don't think any of the function in `Capability.Constraint` are needed in the normal operations of Capability. But if we decide that one is, we should re-export that one specifically.
198e8ad to
7ec5c4b
Compare
Member
|
I've rebased on master and force-pushed. Hopefully that fixes CI. |
aherrmann
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to make the Haddock look good, basically.