Skip to content

Make collapsible 'parent' option independent on '.accordion-group'#7600

Closed
simsalabim wants to merge 1 commit intotwbs:masterfrom
simsalabim:make-collapsible-parent-independent
Closed

Make collapsible 'parent' option independent on '.accordion-group'#7600
simsalabim wants to merge 1 commit intotwbs:masterfrom
simsalabim:make-collapsible-parent-independent

Conversation

@simsalabim
Copy link

Currently parent option of collapsible plugin relies on .accordion-group class, which is quite unobvious and discouraging, because according to the documentation is should not.

parent - type(selector) - default(false); If selector then all collapsible elements under the specified parent will be closed when this collapsible item is shown. (similar to traditional accordion behavior)

And this can't be known unless you browse through the source code.
In this pull request I propose a fix.

@mdo
Copy link
Member

mdo commented May 23, 2013

If this still needs fixing in v3, please resubmit against 3.0.0-wip. Thanks!

@simsalabim
Copy link
Author

@mdo, done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants