Skip to content

Fix Default values and Description content in options table #39846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdo merged 2 commits into from
Jun 13, 2024
Merged

Fix Default values and Description content in options table #39846

mdo merged 2 commits into from
Jun 13, 2024

Conversation

@ZhangChengLin
Copy link
Contributor

@ZhangChengLin ZhangChengLin commented Mar 28, 2024 •
edited
Loading

Description

bootstrap/js/src/popover.js

Lines 20 to 31 in ae43f0c

const Default = {
...Tooltip.Default,
content: '',
offset: [0, 8],
placement: 'right',
template: '<div class="popover" role="tooltip">' +
'<div class="popover-arrow"></div>' +
'<h3 class="popover-header"></h3>' +
'<div class="popover-body"></div>' +
'</div>',
trigger: 'click'
}

bootstrap/js/src/tooltip.js

Lines 58 to 79 in 953b4b6

const Default = {
allowList: DefaultAllowlist,
animation: true,
boundary: 'clippingParents',
container: false,
customClass: '',
delay: 0,
fallbackPlacements: ['top', 'right', 'bottom', 'left'],
html: false,
offset: [0, 6],
placement: 'top',
popperConfig: null,
sanitize: true,
sanitizeFn: null,
selector: false,
template: '<div class="tooltip" role="tooltip">' +
'<div class="tooltip-arrow"></div>' +
'<div class="tooltip-inner"></div>' +
'</div>',
title: '',
trigger: 'hover focus'
}

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@ZhangChengLin
Copy link
Contributor Author

ZhangChengLin commented Mar 28, 2024

Questions that may be related to this also involve css names, for reference.

For example:

bootstrap/scss/_popover.scss

Line 10 in b8880e5

--#{$prefix}popover-inner-border-radius: #{$popover-inner-border-radius};

bootstrap/scss/_variables.scss

Line 1441 in 859a134

$popover-inner-border-radius: calc(#{$popover-border-radius} - #{$popover-border-width}) !default; // stylelint-disable-line function-disallowed-list

@ZhangChengLin ZhangChengLin marked this pull request as ready for review March 28, 2024 05:43
@XhmikosR XhmikosR requested a review from GeoSot April 2, 2024 10:03
@mdo mdo force-pushed the doc-popover-options-template branch from 0654fba to 9c92767 Compare June 13, 2024 01:44
@mdo mdo merged commit d2d4581 into twbs:main Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdo mdo mdo approved these changes

@GeoSot GeoSot Awaiting requested review from GeoSot

Assignees

No one assigned

Labels

docs v5

Projects

No open projects
v5.3.4
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZhangChengLin @mdo @julien-deramond