Simpler input groups: validation roles and test fixes#31677
Merged
mdo merged 4 commits intosimpler-input-groupsfrom Sep 17, 2020
Merged
Simpler input groups: validation roles and test fixes#31677mdo merged 4 commits intosimpler-input-groupsfrom
mdo merged 4 commits intosimpler-input-groupsfrom
Conversation
This was referenced Sep 16, 2020
Closed
Member
Author
|
Going to merge this into the base branch so that one has passing tests. Feel free to leave comments here or in that PR moving forward! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@patrickhlauke Think I got this right, but would love your eyes! This PR is based on #31666 and will merge into that if approved. This PR also fixes the failing tests in the base PR.
I believe this fixes #28414.