Prevent nested tables style leaks#30466
Conversation
5834010 to
719665a
Compare
|
This is pretty damned awesome, pretty powerful. Nicely done! Only feedback on this right now is that I'm really partial to the modified table styles I implemented months back with the darker, single pixel table header border :). In addition, I think we'll need more detailed "how it works" and "how to customize" sections to explain the collision of CSS variables and Sass variables. |
02da595 to
7ead756
Compare
|
Restored the table thead styles (also added the border between multiple Would be handy if I could use #30502 to document things. |
9a461b9 to
1b4c71a
Compare
|
@twbs/css-review, ready for review. @mdo, could you doublecheck the doc edits? |
|
Should the custom CSS property vars be prefixed ( i.e. |
|
@tmorehouse, I've opened #30558 to discuss this, we'll need to change our custom properties in |
1b4c71a to
a0de3d6
Compare
|
|
|
@twbs/css-review, this one is ready to review. |
efa3ad6 to
626e5b6
Compare
|
LGTM |
mdo
left a comment
There was a problem hiding this comment.
Just some docs copy changes, otherwise looks great!
Co-Authored-By: Mark Otto <markd.otto@gmail.com>
24da4d0 to
1e143bd
Compare

Prevent nested table style leaks by using children combinators and CSS custom properties:
tdandthbackgrounds, therefore we need to work with CSS custom properties.$table-variants. This way we have more control over colorizing tables. The dark table is also a variant now.$table-border-factorwill determine the contrast between the background and the borders$table-accent-bg-factorwill determine the contrast between the background and striped rows$table-hover-bg-factorwill determine the contrast between the background and hovered rowscontrast-color()TODO:
Preview: https://deploy-preview-30466--twbs-bootstrap.netlify.com/docs/4.3/content/tables/
activeis now a state and can be applied to any table varianttable-darkis a table variant now