Skip to content

Remove .table-dark as table variant#30193

Closed
MartijnCuppens wants to merge 1 commit intomasterfrom
master-mc-fix-dark-table
Closed

Remove .table-dark as table variant#30193
MartijnCuppens wants to merge 1 commit intomasterfrom
master-mc-fix-dark-table

Conversation

@MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Feb 16, 2020

Remove .table-dark as color variant. .table-dark was already used for inverted tables.

Closes #27879

@ysds
Copy link
Contributor

ysds commented Feb 20, 2020

I thought it would change either name to fix conflicts.

@tomsommer
Copy link

I thought it would change either name to fix conflicts.

I agree this would be a better solution

@ysds
Copy link
Contributor

ysds commented Feb 20, 2020

Ideas of the name:

  • table-highlighted-{theme} and table-active
  • table-variant-{theme} and table-active
  • table-data-{theme} and table-active

@tomsommer
Copy link

tomsommer commented Feb 20, 2020

Why not just rename .table-dark to .table-inverted, .table-inverted-text or .table-text-inverted?

Or even better: remove .table-dark entirely since you can do the same with other utility classes?

@MartijnCuppens
Copy link
Member Author

Or even better: remove .table-dark entirely since you can do the same with other utility classes?

You can't use the current utility classes to change the border colors. On the other hand, it's not that user friendly if you need to add classes to each cell to override border colors.

I thought it would change either name to fix conflicts.

Any suggestions on this approach? I chose to remove the dark variant since the dark, active and secondary table variants look quite alike.

@ysds
Copy link
Contributor

ysds commented Feb 21, 2020

Any suggestions on this approach?

Please see my above comment.

@MartijnCuppens
Copy link
Member Author

My point was: do we really need this many shades of gray? https://codepen.io/MartijnCuppens/pen/dyoOpNV

@ysds
Copy link
Contributor

ysds commented Feb 21, 2020

The gray active and secondary are just by default colors. Users can customize the colors, but dark is dark for everyone.

@ysds
Copy link
Contributor

ysds commented Feb 21, 2020

For example, we need to consider users who have active light blue and secondary pink.

@mdo
Copy link
Member

mdo commented Mar 4, 2020

Wondering if we can nix the .table-dark that inverts things for a series of utilities:

  • .bg-dark for the background-color
  • .text-white for the color change
  • Add new border color utilities

Thoughts?

@mdo
Copy link
Member

mdo commented Mar 5, 2020

Alternate approach opened up at #30342.

@MartijnCuppens MartijnCuppens deleted the master-mc-fix-dark-table branch March 10, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.table-dark is used in two conflicting contexts

4 participants