Skip to content

Row columns 3#29317

Merged
mdo merged 1 commit into
row-colsfrom
row-cols-ysds
Aug 28, 2019
Merged

Row columns 3#29317
mdo merged 1 commit into
row-colsfrom
row-cols-ysds

Conversation

@ysds

@ysds ysds commented Aug 28, 2019

Copy link
Copy Markdown
Contributor

#29073 can not override specific cols width. This PR allows this. e.g.

  <div class="row row-cols-4">
    <div class="col">Column</div>
    <div class="col">Column</div>
    <div class="col-6">Column</div> /* override col width */
    <div class="col">Column</div>
  </div>

https://deploy-preview-29317--twbs-bootstrap.netlify.com/docs/4.3/layout/grid/#row-columns

The difference from #29274 is that row-cols- still needs .col or .col- class for consistency with our traditional rule.

@MartijnCuppens

Copy link
Copy Markdown
Member

I'm in favor of this one

@ysds ysds changed the base branch from master to row-cols August 28, 2019 16:38
@ysds

ysds commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

@mdo I changed the target branch to row-cols. Please merge If you accept this PR :)

@ysds ysds marked this pull request as ready for review August 28, 2019 16:42
@ysds ysds requested a review from a team as a code owner August 28, 2019 16:42
@mdo

mdo commented Aug 28, 2019

Copy link
Copy Markdown
Member

Y’all are the best :D.

@mdo mdo merged commit c5f92e5 into row-cols Aug 28, 2019
@mdo mdo deleted the row-cols-ysds branch August 28, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants