Skip to content

Add missing dropdown unit test for closing with ESC#28929

Merged
XhmikosR merged 2 commits into
v4-devfrom
patrickhlauke-v4-backport-dropdown-unit-test-esc
Jun 19, 2019
Merged

Add missing dropdown unit test for closing with ESC#28929
XhmikosR merged 2 commits into
v4-devfrom
patrickhlauke-v4-backport-dropdown-unit-test-esc

Conversation

@patrickhlauke

Copy link
Copy Markdown
Member

backport of the unit test from #28928

@patrickhlauke patrickhlauke requested a review from a team as a code owner June 18, 2019 22:49
@XhmikosR

Copy link
Copy Markdown
Member

It seems browserstack tests fail.

@Johann-S

Copy link
Copy Markdown
Member

It failed on bundlesize

@patrickhlauke

Copy link
Copy Markdown
Member Author

nah i mixed/matched event dispatch by accident. let me just stash what i'm currently doing and try to fix this...

accidentally used the new-style method from v5 unit test...
@XhmikosR XhmikosR merged commit 5f44e01 into v4-dev Jun 19, 2019
@XhmikosR XhmikosR deleted the patrickhlauke-v4-backport-dropdown-unit-test-esc branch June 19, 2019 10:43
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants