fix custom-select-indicator in IE10#28882
Closed
mort3za wants to merge 304 commits into
Closed
Conversation
Co-Authored-By: Mark Otto <otto@github.com>
Co-Authored-By: Martijn Cuppens <martijn.cuppens@gmail.com>
Notably: * bundlesize 0.15.3 → ^0.17.2 * eslint-plugin-unicorn ^8.0.2 → ^9.0.0 * terser ^3.17.0 → ^4.0.0
…callout (twbs#28851) - Add same advice about keyboard/AT handling to popovers as a callout; also add information about not adding excessive content or interactive controls (and the suggestion to opt for a modal) - Tweak the tooltips callout for consistency
* Remove unused classes/styles and use utilities instead of specific styles * Use `getElementById` instead of `querySelector`
Co-Authored-By: Shohei Yoshida <fellows3@gmail.com>
Co-Authored-By: Shohei Yoshida <fellows3@gmail.com>
Member
|
Hi @mort3za, Thanks for the fix! We're dropping IE10 support in Bootstrap |
Author
|
Yes, I'll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline svg of custom-select is broken in IE10 because there is no width and height attributes.
Tested on a real IE10 in browserstack, it works.
Current: https://getbootstrap.com/docs/4.3/components/forms/#select-menu
Fix: https://deploy-preview-28882--twbs-bootstrap.netlify.com/docs/4.3/components/forms/#select-menu