Remove autocomplete from buttons and radio/checkbox inputs#28649
Closed
patrickhlauke wants to merge 2 commits into
Closed
Remove autocomplete from buttons and radio/checkbox inputs#28649patrickhlauke wants to merge 2 commits into
patrickhlauke wants to merge 2 commits into
Conversation
Member
Author
|
However, note #28623 (comment) ... I've not tested, but is there potential for the autocomplete behaviour to get our styles/behaviours out of sync? If that's the case, I'd tend to say we should keep autocomplete until the bug has been fixed/addressed, as otherwise it'll lead to weird and difficult to debug issues for Firefox users... /cc @mdo |
While the bug in Firefox is still present, apparently (see https://bugzilla.mozilla.org/show_bug.cgi?id=654072) we should remove this (as otherwise we'd need explanations everywhere on why this Firefox-specific workaround has been added everywhere).
3c8e870 to
513e7e7
Compare
Member
|
Rebased. @mdo ping for your opinion. |
Member
Author
|
Closing this, as I'm actually going to tackle the root cause of this (visual presentation of buttons/toggles not matching their real value on page load) |
Member
Author
|
Successor (which fundamentally tackles the problem) #28952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the bug in Firefox is still present, apparently (see https://bugzilla.mozilla.org/show_bug.cgi?id=654072) we should remove this (as otherwise we'd need explanations everywhere on why this Firefox-specific workaround has been added everywhere).
Fixes #28623
/cc @miketaylr