Skip to content

Call toast hide() after delay time#28630

Merged
Johann-S merged 2 commits into
twbs:masterfrom
ysds:toast-hide-timing
Apr 9, 2019
Merged

Call toast hide() after delay time#28630
Johann-S merged 2 commits into
twbs:masterfrom
ysds:toast-hide-timing

Conversation

@ysds

@ysds ysds commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

The hide callback function should be called when start closing the toast.

Fixes #28629

@ysds ysds requested a review from a team as a code owner April 9, 2019 10:25

@Johann-S Johann-S left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking the change, seems a right move to me 👍

Just remove the _close methods and move everything in hide

@ysds

ysds commented Apr 9, 2019

Copy link
Copy Markdown
Contributor Author

@Johann-S Thank you for your review 😄

Just remove the _close methods a move everything in hide

Done!

@Johann-S Johann-S merged commit f4877db into twbs:master Apr 9, 2019
@ysds ysds deleted the toast-hide-timing branch May 7, 2019 10:13
@XhmikosR XhmikosR added the v4 label Jul 16, 2019
@mdo mdo mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toast hide event fired timing

3 participants