Make sure we can tweak the custom-file-border-radius-after#28388
Closed
samdemaeyer wants to merge 2 commits intotwbs:masterfrom
Closed
Make sure we can tweak the custom-file-border-radius-after#28388samdemaeyer wants to merge 2 commits intotwbs:masterfrom
samdemaeyer wants to merge 2 commits intotwbs:masterfrom
Conversation
Member
|
@twbs/css-review: should this be backported in v4? |
Contributor
|
Maybe it would be better to remove border-radius on ::after element and add overflow:hidden to the label? Another ticket is also asking for overflow:hidden. The ticket is #26933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28389.
When the border width for input fields is more than 1px, the radius of the
custom-file-borderlabel after is not correct.This PR introduces a way to customize that radius with a new variable:
$custom-file-border-radius-afterBefore:
After:
