Update _card.scss - border on one card accordions#28060
Closed
dangowans wants to merge 2 commits into
Closed
Conversation
Add back the border for accordions that only have a single card inside.
Member
|
Do we have a demo in the docs to show this one? Want to make sure we're able to see these things better when merging PRs :). |
Author
|
First timer here, so not entirely sure what you mean. (Sorry.) But here's the behaviour I'm seeing. And here's the card accordion with my pull request. |
MartijnCuppens
requested changes
Jan 15, 2019
MartijnCuppens
left a comment
Member
There was a problem hiding this comment.
Hi @dangowans,
Thanks for the PR, but I think we can fix this in one line. Could you just change line 275 to:
&:first-of-type:not(:last-of-type) {
Member
|
@dangowans: ping |
Member
|
@MartijnCuppens can you tackle this yourself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add back the border for accordions that only have a single card inside.