Revert "Remove now unnecessary shrink-to-fit viewport directive" #27855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit af484dc.
629db81 to
3e8689a
Compare
mdo
approved these changes
Dec 16, 2018
Member
|
not sure what the install base of iOS < 9.3 is, to be honest. not precious about removing the directive either way...it does no harm, just superfluous/inactive for anything 9.3+ |
Member
Author
|
It's a breaking change given our browsers support list, either we like it or not. This shouldn't have landed for 4.x. When we change the browsers we support, this can be reapplied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27818
Reasoning: In 4.x we support iOS 9 not 9.3.