Conversation
b0d6ca0 to
97680a3
Compare
97680a3 to
171b8ec
Compare
Johann-S
approved these changes
Nov 5, 2018
mdo
approved these changes
Nov 5, 2018
Member
mdo
left a comment
There was a problem hiding this comment.
Didn't review line-by-line, but I'm in favor! Curious at what point we offer a separate download or built HTML files in our dist directory, but hopefully that can wait :).
Member
Author
|
I'm gonna finish this soon-ish, confirm all is good and then merge :) |
171b8ec to
10e1d4e
Compare
8 tasks
68d5c9c to
3ba3d2e
Compare
Reduces duplication and makes maintenance easier.
3ba3d2e to
64b8ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know in the past we wanted people to get the files from the repo and use them, but this situation results in too much duplication and also cases where things can break.
This should make everything safer and cleaner.
Also, I removed unused JS assets and only include the ones each example needs. We might be able to drop more JS files if they are not used in some examples like in the Cover example where no JS is needed.
Check the non-whitespace diff
TODO: