Skip to content

Revert "Remove custom example plugin."#27491

Closed
XhmikosR wants to merge 1 commit intov4-devfrom
v4-dev-xmr-docs-example-plugin
Closed

Revert "Remove custom example plugin."#27491
XhmikosR wants to merge 1 commit intov4-devfrom
v4-dev-xmr-docs-example-plugin

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 21, 2018

This reverts commit d01b4eb (PR #25784).

This implementation has many limitations/issues.

Closes #27395

@XhmikosR XhmikosR requested review from Johann-S and mdo October 21, 2018 12:17
@XhmikosR XhmikosR changed the title Revert "Remove custom example plugin. (#25784)" Revert "Remove custom example plugin." Oct 21, 2018
@mdo
Copy link
Member

mdo commented Oct 21, 2018

Is this just the holder.js stuff or something else as well? I imagine we could replace holder.js with some SVGs, 1x1 GIFs, etc?

@XhmikosR
Copy link
Member Author

Yup, mostly holder.js. I also suggested SVGs in #27395 but I didn't see any traction. Plus Liquid does not do regular expressions so this cannot be extended any more than exact matches...

All this will be useless with Hugo anyway, but since I don't know when I'll get to finish that, you know.

@m5o
Copy link
Contributor

m5o commented Oct 22, 2018

I don't see these many limitations/issues, to be honest. There is one issue, to be precise.

Isn't the real question to ask, what's the main focus of the html markup example? It's primarly showing and teaching the element structure and bootstrap class naming. The src of the image is secondary.

There are some image placeholder services available with a similar url structure as holder.js. Easiest would, replace it by e.g. //imgplaceholder.com instead of ... ✌️

@XhmikosR
Copy link
Member Author

Well we are not tied to any solution. I just need something that works properly and the current solution does not. It's so simple.

@twbs twbs locked and limited conversation to collaborators Oct 22, 2018
@twbs twbs unlocked this conversation Oct 22, 2018
@twbs twbs deleted a comment from m5o Oct 22, 2018
@twbs twbs deleted a comment from m5o Oct 22, 2018
@XhmikosR
Copy link
Member Author

Putting this on hold for now. I still don't care about using the plugin or not as long as it works for our needs. That being said, it's a good chance to replace holder.js with pure SVGs.

@mdo
Copy link
Member

mdo commented Nov 3, 2018

Removed from v4.2 given the hold.

Edit: Doh, missed the unlock!

@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 3, 2018 via email

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-docs-example-plugin branch from 6349000 to 70b081f Compare November 6, 2018 05:44
This reverts commit d01b4eb.

This implementation has many limitations/issues, namely not being able to use a regex in Liquid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants