Skip to content

Added sizing and spacing based on viewport#27397

Closed
galczo5 wants to merge 3 commits intotwbs:v4-devfrom
galczo5:sizing-spacing-vw-vh
Closed

Added sizing and spacing based on viewport#27397
galczo5 wants to merge 3 commits intotwbs:v4-devfrom
galczo5:sizing-spacing-vw-vh

Conversation

@galczo5
Copy link
Contributor

@galczo5 galczo5 commented Oct 11, 2018

Solution for #26779

@XhmikosR
Copy link
Member

Please make sure all CI is green.

@galczo5
Copy link
Contributor Author

galczo5 commented Oct 20, 2018

I'm not sure what I should do. I've added some scss and output size check failed. Should I change value of check value or try to minimalize my code?

@XhmikosR
Copy link
Member

XhmikosR commented Oct 20, 2018

Yeah, then maybe this shouldn't be added at all. Or if we do really want this feature we will bump the limits, which generally I'm against. We have already too many utilities.

@galczo5
Copy link
Contributor Author

galczo5 commented Oct 20, 2018

I'm not sure about margins and paddings, but w-vw-* and h-vh-* are quite usefull

@XhmikosR
Copy link
Member

XhmikosR commented Oct 20, 2018

Well, usefulness is subjective. We can't add everything.

@mdo
Copy link
Member

mdo commented Oct 20, 2018

Thanks, but I've turned this down before and will do so again. We don't need responsive variations for everything and this just adds too much CSS.

@mdo mdo closed this Oct 20, 2018
@galczo5
Copy link
Contributor Author

galczo5 commented Oct 20, 2018

No problem :) I've been thinking about this for few hours today and you guys have right. In bootstrap there is too many utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants