Skip to content

Change default boundary value to window#26842

Closed
simPod wants to merge 1 commit intotwbs:v4-devfrom
simPod:flicker-tooltip
Closed

Change default boundary value to window#26842
simPod wants to merge 1 commit intotwbs:v4-devfrom
simPod:flicker-tooltip

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Jul 10, 2018

Trying to address these
#25428
floating-ui/floating-ui#535
#26836

@simPod
Copy link
Contributor Author

simPod commented Jul 10, 2018

Needs fixing tests, but not sure if it's viable. It's BC break

@Johann-S
Copy link
Member

The default value is scrollParent because it's the default value specified by Popper.js so we won't change that, unless Popper.js change their default value.

You have the hability to change this value, so there are no need to change that

@Johann-S Johann-S closed this Jul 10, 2018
@simPod
Copy link
Contributor Author

simPod commented Jul 10, 2018

Only the thing that it is the bug 🐛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants