Replace .box-shadow in examples with built-in .shadow utility#26493
Merged
mdo merged 3 commits intotwbs:v4-devfrom Jul 14, 2018
Merged
Replace .box-shadow in examples with built-in .shadow utility#26493mdo merged 3 commits intotwbs:v4-devfrom
mdo merged 3 commits intotwbs:v4-devfrom
Conversation
Contributor
Author
|
@coliff Any updates regarding this issue ? |
Contributor
|
HI @parammittal16 - your issue is currently in the 'Inbox' for possible inclusion to v4.1.2. Now you just need to wait. Hopefully it'll be merged and ship with v4.1.2 but maybe it'll take a little longer. |
Contributor
Author
|
Ok thanks @coliff I hope it will be reviewed and be shipped 👍 soon. |
Contributor
Author
|
Hi @coliff @bardiharborow @mdo my PR was in the inbox yesterday but now it is missing from there ? What happened ?? Any updates ?? |
mdo
requested changes
Jul 7, 2018
Member
mdo
left a comment
There was a problem hiding this comment.
All these instances of box-shadow should be replaced with shadow-sm instead of shadow. Happy to see that done here, or in another PR.
Contributor
Author
|
@mdo Sir I committed the changes that were requested |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the example pages having class box-shadow are replaced by bootstrap inbuilt box-shadow classes and then committed.
Also, the example pages having unused box-shadow class, those pages box-shadow class is also removed and then committed.
Fixes #26377.