Skip to content

Fix custom range thumb style#26385

Merged
mdo merged 7 commits intotwbs:v4-devfrom
ysds:custom-range-thumb-style
Jul 15, 2018
Merged

Fix custom range thumb style#26385
mdo merged 7 commits intotwbs:v4-devfrom
ysds:custom-range-thumb-style

Conversation

@ysds
Copy link
Contributor

@ysds ysds commented Apr 26, 2018

Fixes #26379 and thumb positions.

Demo: https://codepen.io/anon/pen/GdjKop

@mdo mdo merged commit 48c723b into twbs:v4-dev Jul 15, 2018
@mdo mdo mentioned this pull request Jul 15, 2018

// Pseudo-elements must be split across multiple rulesets to have an affect.
// No box-shadow() mixin for focus accessibility.
&::-webkit-slider-thumb { box-shadow: $custom-range-thumb-focus-box-shadow; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysds Doesn't autoprefixer take care of the prefixes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the selectors, no. All these need to be split as the comment says or no browser picks it up. Strange, but it's common across most of these form styles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @mdo said. Also I found @ai's comment in postcss/autoprefixer#279

Main problem here, that we absolutly didn’t know unprefixed version of this selectors. Autoprefixer is developed to be able to remove Autoprefixer and future and your CSS will be worked.

Try PostCSS and create polyfill.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoprefixer can add prefixes in selectors (like it support :: placeholder). But Autoprefixer need to have W3C draft to have unprefixed version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was mostly wondering :)

@ysds ysds deleted the custom-range-thumb-style branch November 4, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants