Conversation
Member
|
@mdo: I pushed a patch to ignore vnu.jar's wrong language code warnings because we get false positives. About the prefixes, https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md#30 Regarding the rename, I don't think you should change the |
XhmikosR
previously requested changes
Mar 29, 2018
docs/4.1/migration.md
Outdated
| ### Responsive utilities | ||
|
|
||
| All `@screen-` variables have been removed in v4.0.0. Use the `media-breakpoint-up()`, `media-breakpoint-down()`, or `media-breakpoint-only()` Sass mixins or the `$grid-breakpoints` Sass map instead. | ||
| All `@screen-` variables have been removed in v4.1.0. Use the `media-breakpoint-up()`, `media-breakpoint-down()`, or `media-breakpoint-only()` Sass mixins or the `$grid-breakpoints` Sass map instead. |
Member
There was a problem hiding this comment.
The migration file shouldn't have the versions changed.
razh
reviewed
Mar 30, 2018
js/src/index.js
Outdated
|
|
||
| if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) { | ||
| throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0') | ||
| throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0') |
Contributor
There was a problem hiding this comment.
This also doesn't need to be changed.
Member
|
@mdo: after you review let me know so that I rebase and clean up the branch before the final merge. |
vsn4ik
approved these changes
Mar 30, 2018
js/src/index.js
Outdated
|
|
||
| if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) { | ||
| throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0') | ||
| throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0') |
Contributor
There was a problem hiding this comment.
This is jQuery version, not Bootstrap.
Member
|
Obviously hence why I reverted it.
…On Sat, Mar 31, 2018, 00:08 Vasilii Artemchuk ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In js/src/index.js
<#25972 (comment)>:
> @@ -31,7 +31,7 @@ import Util from './util'
const maxMajor = 4
if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) {
- throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0')
+ throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0')
This is jQuery version, not Bootstrap.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25972 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtX3kWguQtN0Bszs9Ng_7duqDK_JTks5tjp7egaJpZM4TAk-p>
.
|
Member
Author
ba95b06 to
d6018b0
Compare
d9231f4 to
f099c84
Compare
Member
|
@mdo: when you are back to this, Then run the build script as normal. If you run the |
This was referenced Apr 8, 2018
Merged
Member
Author
|
New PR coming in #26218. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/4.0/todocs/4.1/build/ship.shscript to updated version from4.0.0to4.1.0We need to check some of this out though—I'm seeing some
-webkitprefixes being dropped and I can't recall if those are intentional.