#25842 Remove max-width from table class#25864
Merged
mdo merged 1 commit intotwbs:v4-devfrom Jul 15, 2018
Merged
Conversation
Member
|
Without a demo reproducing these problems you mention, we cannot accept the PR. |
Author
Collaborator
|
@mdo I'll reopen this one since there is an example in this issue #25842 I haven't review the PR yet. |
|
I can confirm this bug happens on iOS Safari with class="table table-dark" and a responsive table div surrounding the table. The dark table only renders to the initial view box. Scroll the table horizontally and the background goes white again. The fix also seems to work fine. So I've done this to fix it for now on the specific table I'm having the issue with: |
mdo
approved these changes
Jul 15, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max-width: 100% was causing issues on
macOs safari
iOs safari
Removed max-width and tested for possible side-effects on:
os: macOs
browsers: Safari, Chrome, Opera, Firefox
and iPhoneX safari (on browserStack)
Fixes #25842