Fix custom-forms heights and position#25602
Merged
mdo merged 4 commits intotwbs:v4-devfrom Jul 15, 2018
unrevised6419:fix-custom-form-heights
Merged
Fix custom-forms heights and position#25602mdo merged 4 commits intotwbs:v4-devfrom unrevised6419:fix-custom-form-heights
custom-forms heights and position#25602mdo merged 4 commits intotwbs:v4-devfrom
unrevised6419:fix-custom-form-heights
Conversation
Now `.custom-control` will have height equal to `$font-size-base` Fix custom checkbox and radio top position (we can't subtract rem from unit) `$line-height-base - $custom-control-indicator-size` is not valid Because `$line-height-base` is a unitless variable and `$custom-control-indicator-size` is a unit (rem) variable
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
.custom-controlwill have height equal to$font-size-base.Fixed custom checkbox and radio top position (we can't subtract rem from unit)
$line-height-base - $custom-control-indicator-sizeis not validBecause
$line-height-baseis a unitless variable and$custom-control-indicator-sizeis a unit (rem) variable