Make dark tables readable for print#25557
Closed
MartijnCuppens wants to merge 2 commits intotwbs:v4-devfrom
Closed
Make dark tables readable for print#25557MartijnCuppens wants to merge 2 commits intotwbs:v4-devfrom
MartijnCuppens wants to merge 2 commits intotwbs:v4-devfrom
Conversation
Member
|
I think I'd rather see us override these styles in our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25453.
The text of dark tables/theads is white and invisible if the page is printed (some browsers don't print backgrounds). Wrapping the theming for dark tables in a
@media not printmedia query will disable theming for dark tables for print.Also I removed the lines which forced the
tds andths to have a white background. If a table/row/cell has an accented background, you would probably also want this when you print the page (if the browser supports coloured backgrounds).