Make 1.9.1 the minimum jQuery version again.#24434
Merged
Conversation
Member
|
It feels inconsistent but we added a warning about that so things will change 😃 and they are warned that's at their own risks so LGTM Plus jQuery 2 match our browser compatibility |
4ac530b to
3c58e79
Compare
Johann-S
approved these changes
Oct 19, 2017
mdo
approved these changes
Oct 19, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll just show a warning message instead.While we don't use 2.x nor test it, a lot of people might still use it.Do not merge yet. I'm still not personally sold we should do this. I do see the point of people using various CMS and not being able to update jQuery, but on the other hand this feels very inconsistent to me...