append btn-* and input-* variables and extends their from input-btn-*…#24430
Closed
isychev wants to merge 2 commits intotwbs:v4-devfrom
Closed
append btn-* and input-* variables and extends their from input-btn-*…#24430isychev wants to merge 2 commits intotwbs:v4-devfrom
isychev wants to merge 2 commits intotwbs:v4-devfrom
Conversation
Merged
houndci-bot
reviewed
Oct 22, 2017
scss/_variables.scss
Outdated
| $input-btn-border-width: $border-width !default; // For form controls and buttons | ||
| $input-box-shadow: inset 0 1px 1px rgba($black, .075) !default; | ||
| $input-border-width: $input-btn-border-width !default; | ||
| $input-box-shadow: inset 0 1px 1px rgba($black,.075) !default; |
There was a problem hiding this comment.
Expected single space after "," in a single-line function function-comma-space-after
andresgalante
approved these changes
Oct 23, 2017
Collaborator
andresgalante
left a comment
There was a problem hiding this comment.
@mdo the "Buttons + Forms" section is a good solution to organize input variables before buttons
I tested it as much as I could and everything works as it should.
Big 👍 to this one.
Member
|
So this is somehow merged into v4-dev now... I dunno how I screwed up the git history, but it's all outta whack in this PR. Good news is the changes are in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons and input inherit the padding from the $input-btn-padding-x and $input-btn-padding-y. For $input-btn-padding-y is entirely true, for there is a problem with $input-btn-padding-x, y buttons, large side indent and have indented input is much less.
Corrected this flaw and modified desires in #24265 (comment)
Fixes #23550.