Skip to content

Removes margin for pre on _code.scss since it's already set on _reboot.scss#24366

Merged
XhmikosR merged 2 commits intov4-devfrom
v4-dev-andres-removes-duplicated-margin-on-pre
Oct 20, 2017
Merged

Removes margin for pre on _code.scss since it's already set on _reboot.scss#24366
XhmikosR merged 2 commits intov4-devfrom
v4-dev-andres-removes-duplicated-margin-on-pre

Conversation

@andresgalante
Copy link
Collaborator

Reboot defines margins for pre https://github.com/twbs/bootstrap/blob/v4-dev/scss/_reboot.scss#L247-L249

This PR removes the pre margin definition on _code.scss

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, slating for Beta 3 so we can slim down remaining Beta 2 todos.

@mdo mdo mentioned this pull request Oct 20, 2017
@XhmikosR XhmikosR merged commit a89187f into v4-dev Oct 20, 2017
@XhmikosR XhmikosR deleted the v4-dev-andres-removes-duplicated-margin-on-pre branch October 20, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants