example plugin: add data-example-id only if it's been supplied.#24127
Merged
example plugin: add data-example-id only if it's been supplied.#24127
data-example-id only if it's been supplied.#24127Conversation
Member
|
What's the goal of this PR @XhmikosR ? |
Member
Author
|
Without this, we insert |
bkeeton12
approved these changes
Sep 27, 2017
bardiharborow
approved these changes
Sep 27, 2017
Member
bardiharborow
left a comment
There was a problem hiding this comment.
My Ruby is terrible too, but I think I can get away with reviewing a ternary operator. :)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Ruby knowledge is pretty basic, but this seems to do the job.