Add style for non-overlapping scrollbar in IE#24081
Merged
XhmikosR merged 3 commits intotwbs:v4-devfrom Sep 26, 2017
prateekgoel:ie-scrollbar-issue
Merged
Add style for non-overlapping scrollbar in IE#24081XhmikosR merged 3 commits intotwbs:v4-devfrom prateekgoel:ie-scrollbar-issue
XhmikosR merged 3 commits intotwbs:v4-devfrom
prateekgoel:ie-scrollbar-issue
Conversation
Member
|
Not sure if this change should be applied to Bootstrap or to our docs CSS 🤔 |
Member
|
Does the issue happen in all |
Contributor
Author
|
Yes, it happens in all. |
Member
|
@Johann-S: can you confirm? |
Member
|
yep I reproduced that bug on Win7 IE 11, but to see it you have to move your cursor over our |
XhmikosR
approved these changes
Sep 26, 2017
mdo
approved these changes
Sep 26, 2017
Member
mdo
left a comment
There was a problem hiding this comment.
Good to go other than this one formatting comment...
scss/_reboot.scss
Outdated
| // Don't allow content to break outside | ||
| overflow: auto; | ||
| // We have @viewport set which causes scrollbars to overlap content in IE11 and Edge, so | ||
| // we force a non-overlapping, non-auto-hiding scrollbar to counteract. |
Member
There was a problem hiding this comment.
Too many spaces here between // and we.
Member
|
@prateekgoel: please don't remove the option to allow project members to edit your PRs. |
Contributor
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
-ms-overflow-style: scrollbar;to resolve overlapping scrollbar issue in IE 11 and Edge.Fixes #24057
Before
After
